Cassandra Schema and Value Mapping #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VardhanThigle
force-pushed
the
cassandra-mapping
branch
from
678b789 to
f9f00fc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
============================================
+ Coverage 45.98% 46.16% +0.17%
- Complexity 3812 4167 +355
============================================
Files 851 856 +5
Lines 50844 51010 +166
Branches 5359 5365 +6
============================================
+ Hits 23383 23547 +164
- Misses 25759 25760 +1
- Partials 1702 1703 +1
|
VardhanThigle
force-pushed
the
cassandra-mapping
branch
9 times, most recently
from
9a82e35 to
3d23485
Compare
VardhanThigle
force-pushed
the
cassandra-mapping
branch
from
3d23485 to
d3fe56c
Compare
VardhanThigle
force-pushed
the
cassandra-mapping
branch
6 times, most recently
from
46039b0 to
452f060
Compare
VardhanThigle
requested review from
Deep1998,
bharadwaj-aditya,
darshan-sj and
shreyakhajanchi
VardhanThigle
force-pushed
the
cassandra-mapping
branch
from
452f060 to
44d8587
Compare
VardhanThigle
force-pushed
the
cassandra-mapping
branch
2 times, most recently
from
8118ab4 to
677859f
Compare
VardhanThigle
force-pushed
the
cassandra-mapping
branch
from
677859f to
a707306
Compare
Deep1998
reviewed
Dec 12, 2024
.../google/cloud/teleport/v2/source/reader/io/cassandra/mappings/CassandraMappingsProvider.java
Show resolved
Hide resolved
Deep1998
reviewed
Dec 12, 2024
...main/java/com/google/cloud/teleport/v2/source/reader/io/cassandra/rowmapper/FieldMapper.java
Show resolved
Hide resolved
VardhanThigle
force-pushed
the
cassandra-mapping
branch
from
a707306 to
b1f60a1
Compare
Contributor
|
LGTM |
Contributor
bharadwaj-aditya
left a comment
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
Looks fine overall. Please address the comments before merging.
...in/java/com/google/cloud/teleport/v2/datastream/transforms/FormatDatastreamRecordToJson.java
Outdated
Show resolved
Hide resolved
...in/java/com/google/cloud/teleport/v2/datastream/transforms/FormatDatastreamRecordToJson.java
Show resolved
Hide resolved
.../google/cloud/teleport/v2/source/reader/io/cassandra/mappings/CassandraMappingsProvider.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/cloud/teleport/v2/source/reader/io/cassandra/rowmapper/RowMapper.java
Outdated
Show resolved
Hide resolved
...java/com/google/cloud/teleport/v2/source/reader/io/schema/typemapping/UnifiedTypeMapper.java
Show resolved
Hide resolved
...on/src/test/java/com/google/cloud/teleport/v2/spanner/migrations/avro/AvroTestingHelper.java
Show resolved
Hide resolved
VardhanThigle
force-pushed
the
cassandra-mapping
branch
3 times, most recently
from
37a95ec to
b9af015
Compare
Deep1998
approved these changes
Dec 13, 2024
VardhanThigle
force-pushed
the
cassandra-mapping
branch
from
b9af015 to
b277aa2
Compare
VardhanThigle
commented
Dec 14, 2024
Contributor
Author
VardhanThigle
left a comment
VardhanThigle
left a comment
There was a problem hiding this comment.
IT tests are failing, due to
{"errors":[{"code":"TOOMANYREQUESTS","message":"Quota exceeded for quota metric 'Requests per project in the US multi-region' and limit 'Requests per project in the US multi-region per minute' of service 'artifactregistry.googleapis.com' for consumer 'project_number:167633336322'."}]}The same workflow had passed on this PR 13 hours ago.
Even the scheduled workflow on main seems to be flaky.
VardhanThigle
merged commit cd28d01
into
GoogleCloudPlatform:main
22 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cassandra Schema and Data mapping for primitive types.
This PR covers mapping of primitive types to Avro for Cassandra.
As of this PR, all the non-primitive types are mapped to
null.TODOS:
CassandraIO.