-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PostgreSQL string pkeys support #1905
Merged
VardhanThigle
merged 10 commits into
GoogleCloudPlatform:main
from
thiagotnunes:pg-string-pks
Oct 22, 2024
Merged
feat: add PostgreSQL string pkeys support #1905
VardhanThigle
merged 10 commits into
GoogleCloudPlatform:main
from
thiagotnunes:pg-string-pks
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
============================================
+ Coverage 44.81% 52.03% +7.21%
+ Complexity 3564 1304 -2260
============================================
Files 832 371 -461
Lines 49479 20336 -29143
Branches 5196 2054 -3142
============================================
- Hits 22172 10581 -11591
+ Misses 25656 9091 -16565
+ Partials 1651 664 -987
|
Implement collations query for the PostgreSQL adapter to allow for String primary keys.
thiagotnunes
force-pushed
the
pg-string-pks
branch
from
September 30, 2024 06:54
24b1742
to
7e1563d
Compare
v2/sourcedb-to-spanner/src/main/resources/sql/postgresql_collation_order_query.sql
Show resolved
Hide resolved
…wTemplates into pg-string-pks
…wTemplates into pg-string-pks
…wTemplates into pg-string-pks
…wTemplates into pg-string-pks
VardhanThigle
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement collations query for the PostgreSQL adapter to allow for String primary keys.