Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Archetypes: version management at the top-level outside archetype source code #566

Merged
davorbonaci merged 3 commits into from
May 4, 2017
Merged

Archetypes: version management at the top-level outside archetype source code #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b18983
Archetypes: version management at the top-level outside archetype sou…
davorbonaci Apr 28, 2017
3bedec3
Add comment to pom.xml explaining archetype.sdk_version_dependency
davorbonaci May 4, 2017
0e93387
Add comment to pom.xml explaining "archetype.sdk_version_dependency"
davorbonaci May 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maven-archetypes/examples-java8/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<dependency>
<groupId>com.google.cloud.dataflow</groupId>
<artifactId>google-cloud-dataflow-java-sdk-all</artifactId>
<version>2.0.0-beta4-SNAPSHOT</version>
<version>@archetype.sdk_version_dependency@</version>
</dependency>

<!-- Dependencies below this line are specific dependencies needed by the examples code. -->
Expand Down
2 changes: 1 addition & 1 deletion maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<dependency>
<groupId>com.google.cloud.dataflow</groupId>
<artifactId>google-cloud-dataflow-java-sdk-all</artifactId>
<version>2.0.0-beta4-SNAPSHOT</version>
<version>@archetype.sdk_version_dependency@</version>
</dependency>

<!-- Dependencies below this line are specific dependencies needed by the examples code. -->
Expand Down
34 changes: 34 additions & 0 deletions maven-archetypes/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,38 @@
<module>examples</module>
<module>examples-java8</module>
</modules>

<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<configuration>
<delimiters>
<delimiter>@</delimiter>
</delimiters>
<useDefaultDelimiters>false</useDefaultDelimiters>
</configuration>
</plugin>
</plugins>
</pluginManagement>

<resources>
<resource>
<directory>src/main/resources</directory>
<filtering>true</filtering>
<includes>
<include>archetype-resources/pom.xml</include>
</includes>
</resource>
<resource>
<directory>src/main/resources</directory>
<filtering>false</filtering>
<excludes>
<exclude>archetype-resources/pom.xml</exclude>
</excludes>
</resource>
</resources>
</build>
</project>
2 changes: 1 addition & 1 deletion maven-archetypes/starter/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<dependency>
<groupId>com.google.cloud.dataflow</groupId>
<artifactId>google-cloud-dataflow-java-sdk-all</artifactId>
<version>2.0.0-beta4-SNAPSHOT</version>
<version>@archetype.sdk_version_dependency@</version>
</dependency>

<!-- slf4j API frontend binding with JUL backend -->
Expand Down
13 changes: 13 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@
<dataflow.release_name>Google Cloud Dataflow SDK for Java</dataflow.release_name>
<dataflow.container_version>${project.version}-20170317</dataflow.container_version>
<dataflow.environment_major_version>6</dataflow.environment_major_version>

<!-- Archetype version propagated automatically to underlying archetype modules.
Example values are: ${project.version}, 1.2.3-SNAPSHOT, [1.0.0,2),
[${project.version}, 2), etc.
Starter archetype reference copy isn't affected by this value; a manual
change is expected there. -->
<archetype.sdk_version_dependency>2.0.0-beta4-SNAPSHOT</archetype.sdk_version_dependency>
</properties>

<packaging>pom</packaging>
Expand Down Expand Up @@ -262,6 +269,12 @@
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<version>3.0.2</version>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
Expand Down