Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Add NOTICE to archetypes and enforce they match the root NOTICE #521

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Add NOTICE to archetypes and enforce they match the root NOTICE #521

merged 1 commit into from
Jan 6, 2017

Conversation

dhalperi
Copy link
Contributor

@dhalperi dhalperi commented Jan 6, 2017

No description provided.

@dhalperi
Copy link
Contributor Author

dhalperi commented Jan 6, 2017

Alternate tried:

  • Instead of copying NOTICE in the root resources, use ../../../../../../NOTICE to try to pick it up from root. Did not work, but did not throw an error either.

Copy link
Contributor

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unless we find a better solution.

@@ -44,7 +44,12 @@ before_install:
- if [ "$TRAVIS_OS_NAME" == "linux" ]; then jdk_switcher use "$CUSTOM_JDK"; fi

install:
- travis_retry mvn install clean -U -DskipTests=true
- travis_retry mvn install -U -DskipTests=true
- mvn clean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn install clean above, instead of two separate commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love overly complicated Maven command lines, but reverted.

@dhalperi dhalperi merged commit 02c6bc6 into GoogleCloudPlatform:v2 Jan 6, 2017
@dhalperi dhalperi deleted the archetype-notice branch January 6, 2017 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants