This repository was archived by the owner on Nov 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 322
Disable Maven forking in Travis-CI to fix build issues #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that truncate mode is not supported for unbounded PCollection. Error message: [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.1:java (default-cli) on project google-cloud-dataflow-java-examples-all: An exception occured while executing th e Java class. null: InvocationTargetException: WriteDisposition.WRITE_TRUNCATE is not supported for unbounded PCollections or when using tablespec functions. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Ugh, now causing OS X build problems. Unassigning |
Attempt to fix build issues. See: travis-ci/travis-ci#3396
Problems fixed; involved a test matrix rewrite. Though the new matrix is much cleaner. See the updated PR description. |
LGTM. Merging. |
davorbonaci
added a commit
that referenced
this pull request
Feb 10, 2016
Disable Maven forking in Travis-CI to fix build issues
robertwb
pushed a commit
to robertwb/DataflowJavaSDK
that referenced
this pull request
Feb 19, 2016
Disable Maven forking in Travis-CI to fix build issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Problems with JDK on sudo:false instances travis-ci/travis-ci#3396. Basically, there's an error that does not properly pass -Xmx and similar arguments to the forked JVMs that Javadoc, Surefire, and other plugins invoke. This bug causes the forked JVMs to exceed the container's RAM limit, the JVMs to get killed, and the builds to fail.
Disabling the forking by setting
-DforkCount=0
in the Maven command seems to have resolved the issue, and it does not slow down build time much.However, the underlying bug seems to only affect Linux VMs, and not OS X. Additionally, disabling forking in the OS X tests causes them to fail for another lingering Travis issue (PermSize in OS X). So, I rewrote the test matrix to only disable forking with the above argument for Linux tests.
In the cleanup, I rewrote the test matrix for Travis to be simpler and cleaner.