Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : added hover animation to sample data #1355

Merged

Conversation

harsh26shah03
Copy link
Contributor

@harsh26shah03 harsh26shah03 commented Apr 3, 2023

Sample data: on hover added minimal scale effect

see,

Screen.Recording.2023-04-03.at.2.58.15.PM.mov

Closed #871

Copy link
Member

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

half of this certainly pacifies the hover feature, but the other half feels like a suggestion for a separate PR. Can you break out the file size suffix suggestion into a separate PR please?

@harsh26shah03
Copy link
Contributor Author

Sure, you will have a PR raised and file size in this PR will be undone.

@harsh26shah03 harsh26shah03 changed the title Feat : changed unit of sample data and added hover animation Feat : added hover animation to sample data Apr 4, 2023
@harsh26shah03
Copy link
Contributor Author

@argyleink ready for review

Copy link
Member

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! works as advertised <3

@argyleink argyleink merged commit 6cb64a5 into GoogleChromeLabs:dev Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new homepage] samples images need focus/hover styles
2 participants