Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sourcemap files when renaming .mjs to .js #777

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

westonruter
Copy link
Collaborator

This follows up on something I missed in 46aa70a (as part of #578). Namely, I saw in the console:

DevTools failed to load source map: Could not load content for .../pwa/wp-includes/js/workbox-v6.5.3/workbox-window.dev.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

The issue is that when I renamed .mjs to .js I didn't also rename the .mjs.map to .js.map. This results in the following change to the build:

130c130
< ./wp-includes/js/workbox-v6.5.3/workbox-window.dev.es5.mjs.map
---
> ./wp-includes/js/workbox-v6.5.3/workbox-window.dev.es5.js.map
132c132
< ./wp-includes/js/workbox-v6.5.3/workbox-window.dev.mjs.map
---
> ./wp-includes/js/workbox-v6.5.3/workbox-window.dev.js.map
136c136
< ./wp-includes/js/workbox-v6.5.3/workbox-window.prod.es5.mjs.map
---
> ./wp-includes/js/workbox-v6.5.3/workbox-window.prod.es5.js.map
138c138
< ./wp-includes/js/workbox-v6.5.3/workbox-window.prod.mjs.map
---
> ./wp-includes/js/workbox-v6.5.3/workbox-window.prod.js.map

@westonruter westonruter added this to the 0.7 milestone Apr 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #777 (800a6ec) into develop (949d03d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #777   +/-   ##
==========================================
  Coverage      19.01%   19.01%           
  Complexity       346      346           
==========================================
  Files             57       57           
  Lines           2324     2324           
==========================================
  Hits             442      442           
  Misses          1882     1882           
Flag Coverage Δ
php 19.01% <ø> (ø)
unit 19.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949d03d...800a6ec. Read the comment docs.

@westonruter westonruter merged commit 7ade9ff into develop Apr 29, 2022
@westonruter westonruter deleted the fix/missing-sourcemaps branch April 29, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants