Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site Icon tests for Site Health and warnings in Customizer control #702

Merged
merged 69 commits into from
Apr 1, 2022
Merged

Add Site Icon tests for Site Health and warnings in Customizer control #702

Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
d18eeed
Add js for maskable icon customizer preview settings
thelovekesh Feb 11, 2022
7d9e93e
Add icon purpose as `any maskable` if user have not checked site icon…
thelovekesh Feb 11, 2022
cd67ec2
Update to show icon as maskable when user uplaods site-icon
thelovekesh Feb 11, 2022
df60ff3
Update theme_mod type in settings with option
thelovekesh Feb 11, 2022
e147659
Move code from manifest to admin
Feb 11, 2022
c0005c8
Optimize JS for icon handling
Feb 11, 2022
c9e7bca
Fix: Add mask when image updated
Feb 11, 2022
5172a07
Update function names
Feb 11, 2022
2a50729
Fix: Icon toggling
Feb 11, 2022
e07955f
Use default maskable set from option
Feb 11, 2022
9657a3c
Fix eslint warnings
thelovekesh Feb 12, 2022
9e96825
Fix site icon purpose addition in manifest
thelovekesh Feb 13, 2022
7e73f78
Remove maskbale icon setting registration
thelovekesh Feb 13, 2022
8850990
Add file for regestring maskable icon setting
thelovekesh Feb 13, 2022
940ce83
Add customizer manager class for init
thelovekesh Feb 13, 2022
6cf206e
Fix showing and hiding of maskable icon setting based on site icon
thelovekesh Feb 13, 2022
5e93c75
Move customizer script to wp-admin folder
thelovekesh Feb 13, 2022
3a6a0ea
Fix: Initial checkbox state
Feb 11, 2022
da51dfe
Update: Set maskable icon setting visibility from js
thelovekesh Feb 13, 2022
a4f6e46
Remove active_callback as already implemented in js
thelovekesh Feb 13, 2022
9c1e043
Fix phpcs errors
thelovekesh Feb 13, 2022
5a43714
Add inline doc and fix adding of icon purpose
thelovekesh Feb 13, 2022
d25f371
Add test cases for maskable icon customizer settings
thelovekesh Feb 14, 2022
99a09e5
Add test cases for adding icon purpose in manifest
thelovekesh Feb 14, 2022
15b8bbe
Remove empty file for adding tests related to admin.php
thelovekesh Feb 14, 2022
bb106bc
Enqueue site icon default value
Feb 14, 2022
8bd06ea
Remove redundant code
Feb 14, 2022
6d18007
Fix: Linting
Feb 14, 2022
540b96d
Remove section binind on expend event
thelovekesh Feb 14, 2022
261f9fc
Add active_callback and remove inline js for sending site_icon value
thelovekesh Feb 14, 2022
053abf0
Remove customizer js from wp-includes
thelovekesh Feb 14, 2022
9796921
Fix: Checkbox toggle and state management
Feb 14, 2022
9db329f
Rename pwa_maskable_icon option to site_icon_maskable
westonruter Feb 15, 2022
aa53d84
Use priority on site_icon to set priority of site_icon_maskable
westonruter Feb 15, 2022
cd6f5ff
Improve method, dependency, and file naming
westonruter Feb 15, 2022
aef39e2
Simplify logic for managing site_icon_maskable active state
westonruter Feb 15, 2022
6e6a187
Refactor logic to better utilize Customizer JS API
westonruter Feb 15, 2022
9c18eda
Fix logic inversion for maskable icon
westonruter Feb 15, 2022
f1c834d
Add missing covers tags
westonruter Feb 15, 2022
1fd98ec
Merge branch 'feature/304-makable-icon-setting' into feature/integration
Feb 16, 2022
7621c6e
Add site health tests for the site icon
thelovekesh Feb 14, 2022
34b02e5
Fix: DocBlock
thelovekesh Feb 14, 2022
c37d7e9
Update wp_getimagesize function with wp_get_attachment_metadata
thelovekesh Feb 15, 2022
88b1986
Add image for testing the site icon
thelovekesh Feb 15, 2022
dccd1b2
Add tests for validating site icons
thelovekesh Feb 15, 2022
5595f72
Fix: return type
Feb 16, 2022
b58c78b
JS: Validation for icon
Feb 16, 2022
8033350
Fix: Linting
Feb 16, 2022
eb120de
Merge branch 'develop' of github.com:GoogleChromeLabs/pwa-wp into fea…
westonruter Mar 30, 2022
89b9d58
Skip test_pwa_validate_site_icon_not_png on PHP 7.1
westonruter Mar 31, 2022
ca01f7b
Reuse existing variable and improve variable name
westonruter Mar 31, 2022
eac70d9
Use warning notification type
westonruter Mar 31, 2022
85f590a
Add notifications to control instead of section
westonruter Mar 31, 2022
e7d0c61
Improve function name
westonruter Mar 31, 2022
44f13f5
Use attachment data for notifications and update notifications when s…
westonruter Mar 31, 2022
d6c815a
Show missing icon notification when attachment is no longer present
westonruter Mar 31, 2022
5bbe720
Remove extraneous variable
westonruter Mar 31, 2022
b27018d
Reuse l10n object in Customizer
westonruter Mar 31, 2022
dc25901
Add warning notifications for non-PNG and non-square icons
westonruter Mar 31, 2022
92da073
Improve strings and presentation of site health test
westonruter Mar 31, 2022
4d545fd
Improve method naming and return value
westonruter Mar 31, 2022
e6a716d
Fix boolean condition for whether icon is too small
westonruter Mar 31, 2022
bb4cac4
Remove extraneous comments
westonruter Mar 31, 2022
d06a61d
Reset notifications when site icon has been removed
westonruter Mar 31, 2022
bca28f1
Improve name of JS file
westonruter Mar 31, 2022
79b9c57
Add paragraph wrapper and harden translation escaping
westonruter Mar 31, 2022
12586a1
Add customize cap check before adding button to Customizer
westonruter Mar 31, 2022
b1d7399
Further generalize naming for site icon code after bca28f1af
westonruter Apr 1, 2022
adda38a
Improve test phpdoc descriptions
westonruter Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update theme_mod type in settings with option
  • Loading branch information
@thelovekesh
thelovekesh authored and Ankit Gade committed Feb 16, 2022
commit df60ff3a8c27c641ce3e3c6a490989e639268b99
2 changes: 1 addition & 1 deletion wp-includes/class-wp-web-app-manifest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ public function get_manifest() {
$manifest['icons'] = $manifest_icons;
}

$manifest_icon_maskable = get_theme_mod( 'pwa_maskable_icon', false );
$manifest_icon_maskable = get_option( 'pwa_maskable_icon', false );
if ( ! $manifest_icon_maskable ) {
$manifest['icons'] = array_map(
function ( $icon ) {
Expand Down