Export more classes/types publicly #2955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tropicadri
Fixes #1824, fixes #2952
The additional exports of TypeScript types that might be useful to some developers via the top-level
index.ts
is hopefully not controversial.There are also two previously private, internal classes in the
workbox-background-sync
module that this PR makes public. Based on the initial issue request, there's a use for developers accessing these directly, but I've warned in the JSDoc that most developers shouldn't. You've touched theworkbox-background-sync
code most recently, @tropicadri, so I'll defer to whether you anticipate any problems with making those classes public.