-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lint-staged to run prettier #2947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TS lint is complaining of a couple of issues other than that it lgtm
Some of the linting issues were introduced by That also made me realize that I neglected to add back the I also will update our guide to contributing code in a separate PR to clearly spell out what needs to be done to get up and running locally, including on Windows. |
Fixes #2944, hopefully. It seems to work as expected when I tested on a Windows tablet using Power Shell, with
node
andnpm
manually installed.This switches to using
lint-staged
to orchestrate that process instead ofgit-format-staged
.Also, when investigating this issue, I realized that the glob patterns in our
.prettierignore
were not configured properly, and there were a bunch of TypeScript source files that should have been formatted, but weren't. So the cosmetic fixes to all those files got picked up in this PR as well.CC: @StephanBijzitter