Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving lint and build into test dependencies. #116

Merged
merged 4 commits into from
Jan 11, 2017
Merged

Conversation

gauntface
Copy link

R: @jeffposnick @addyosmani

Fixes #115

One problem I hit is that gulp-eslint seems to exit the gulp process early. I stumbled across a hack to make it work by adding gulp-debug to the pipe chain, but I'm not sure what the problem is.

But this change does mean testing will always be run against a new build and linting is now part of the test task.

@jeffposnick
Copy link
Contributor

Regarding the gulp-debug bit, I'm diving into what's going on to try to isolate the source of breakage independent of this PR.

I have a minimal reproduction of the aborted gulp process when just running a gulp lint project='sw-lib' and gulp lint project='sw-precaching' against the current master, with all the other projects seeming to complete without issue.

I'm going to poke around a bit more to see what those two projects have in common w.r.t. linting. (I feel like this might be why, when I run gulp lint locally, it doesn't pick up some of the things that Travis CI picks up—gulp lint is also aborting early, while Travis CI now does per-project linting.)

I'd like to hold off on merging this PR until we can clean up whatever that issue is, and then we can hopefully omit the gulp-debug hack.

@gauntface
Copy link
Author

Would you accept this PR if I remove lint from the test task?

I specifically wanted build and test to work together, linting was a nice to have.

@jeffposnick
Copy link
Contributor

Yes, if you could remove the linting and the hacky bits, I'd be fine with this PR. I'll file a separate issue to investigate what's going on with the linting failures.

@jeffposnick
Copy link
Contributor

(See #119)

@jeffposnick
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants