Skip to content

Conversation

@brendandahl
Copy link
Collaborator

@brendandahl brendandahl commented Jan 22, 2026

The full e2e tests are very slow, but they pass with an increased timeout.

Enabled for chrome only for now.

Fixes #60

Just checking to see how far this gets currently or if we need to disable
webgpu tests.
@brendandahl brendandahl changed the title [WIP] Enable testing on github actions. Enable github action for testing Jan 23, 2026
@brendandahl brendandahl changed the title Enable github action for testing Add github action for testing Jan 23, 2026
runs-on: macos-latest
strategy:
matrix:
# TODO enable safari and firefox
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side comment: I've seen that there are some resource limitations with macos so I've split the tasks in JetStream to be able to run on linux (though these are slightly slower machines).

https://github.com/WebKit/JetStream/blob/main/.github/workflows/test.yml

Copy link
Collaborator

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

async function test() {
try {
await driver.manage().setTimeouts({ script: 60000 });
await driver.manage().setTimeouts({ script: 20 * 60000 });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small nit: Could you make 60000 a const ONE_MINUTE_IN_MS = 60000 or so, to make this a somewhat less magic number?

Also, at a high-level: 20 minutes is a really long time out, do we have a lighter workload?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a lighter workload, we could run one benchmark from each of the frameworks and backend types. e.g. 1 transformerjs w/ wasm/gpu, 1 tflite w/ wasm/gpu. They're all basically the same code so that'd probably catch most problems.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided it would be a bit better to get more coverage and do all wasm tests and 2 gpu tests (1 from tflite and transformers). The wasm tests tests on CI seem relatively quick.

Copy link
Collaborator

@rmahdav rmahdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brendan!

@brendandahl brendandahl requested a review from danleh January 28, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI tests

4 participants