Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

build(cloudbuild): migrate deploy to cloud build #6082

Merged
merged 5 commits into from
Sep 2, 2021
Merged

build(cloudbuild): migrate deploy to cloud build #6082

merged 5 commits into from
Sep 2, 2021

Conversation

MichaelSolati
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 1, 2021 •
edited
Loading

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: 7dd190b

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/613011275c3fc700085e6ef1

😎 Browse the preview: https://deploy-preview-6082--web-dev-staging.netlify.app

@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Sep 1, 2021
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

README.md

  • Please change your usage of the following words:
    • Avoid please. Affected lines: 12

samthor
samthor reviewed Sep 1, 2021
View reviewed changes
README.md
2. Click the **Run workflow** button. Make sure the branch says `main`, then click the green **Run workflow** button.

![An expanded workflow popup with a green run workflow button inside of it.](https://user-images.githubusercontent.com/1066253/89584965-da6eb500-d7f1-11ea-8a43-d8b1abe2cd3b.png)
1. Navigate to [the Cloud Build Triggers page](https://console.cloud.google.com/cloud-build/triggers?project=web-dev-production-1).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but I want to note here—like we do for dcc, I think—that in practice because this will happen every ~hours, you need to stop or disable that task for manual builds to really make sense. Can you add a comment?

@MichaelSolati MichaelSolati merged commit f048ef0 into main Sep 2, 2021
@MichaelSolati MichaelSolati deleted the build/cloudbuild branch September 2, 2021 01:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samthor samthor samthor approved these changes

@robdodson robdodson Awaiting requested review from robdodson

Assignees
No one assigned
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelSolati @chrome-devrel-review-bot @samthor