webtransport: Update server #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example test page (client.html) should work on Chrome 91+.
|
@jeffposnick PTAL when you have time? |
|
Thank you very much for submitting this! I tried it out with a locally generated key and certificate, and things appeared to work fine with Chrome 93. However, @vasilvv was the one who wrote the original server code, and I would feel best about letting them weigh in before merging this, just in case there are any other changes that need to be made. I'll reach out to @vasilvv directly via email as well, as I'm not sure if they check their GitHub notifications. |
|
Merging after consultation with some members of the team. |
guest271314
reviewed
Aug 5, 2021
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@yutakahirano FYI |
|
Oops, I was confused, sorry. Yes, we should update https://github.com/GoogleChrome/samples/tree/gh-pages/webtransport. |
This comment was marked as off-topic.
This comment was marked as off-topic.
markafoltz
pushed a commit
that referenced
this pull request
Oct 14, 2024
The example test page (client.html) should work on Chrome 91+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example test page (client.html) should work on Chrome 91+ with this update.