Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: update seo group titles and descriptions #8378

Merged
merged 2 commits into from
Apr 17, 2019
Merged

i18n: update seo group titles and descriptions #8378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a9cb17
Update group i18n
exterkamp Apr 17, 2019
788a6c0
Update sample json.
exterkamp Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions lighthouse-core/config/default-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,19 @@ const UIStrings = {
'[Learn more](https://support.google.com/webmasters/answer/35769).',
/** Description of the Search Engine Optimization (SEO) manual checks category, the additional validators must be run by hand in order to check all SEO best practices. This is displayed at the top of a list of manually run audits focused on optimizing a website for indexing by search engines. No character length limits. */
seoCategoryManualDescription: 'Run these additional validators on your site to check additional SEO best practices.',
/* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */
seoMobileGroupTitle: 'Mobile Friendly',
/* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */
seoMobileGroupDescription: 'Make sure your pages are mobile friendly so users don’t have to pinch or zoom ' +
'in order to read the content pages. [Learn more](https://developers.google.com/search/mobile-sites/).',
/* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website content more easily understood by search engine crawler bots. */
seoContentGroupTitle: 'Content Best Practices',
/* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website content more easily understood by search engine crawler bots. */
seoContentGroupDescription: 'Format your HTML in a way that enables crawlers to better understand your app’s content.',
/* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website accessible to search engine crawlers. */
seoCrawlingGroupTitle: 'Crawling and Indexing',
/* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website accessible to search engine crawlers. */
seoCrawlingGroupDescription: 'To appear in search results, crawlers need access to your app.',
/** Title of the Fast and Reliable section of the web app category. Within this section are audits that check if the web site loaded quickly and can reliably load even if the internet connection is very slow or goes offline. */
pwaFastReliableGroupTitle: 'Fast and reliable',
/** Title of the Installable section of the web app category. Within this section are audits that check if Chrome supports installing the web site as an app on their device. */
Expand Down Expand Up @@ -319,17 +332,16 @@ const defaultConfig = {
description: str_(UIStrings.a11yTablesListsVideoGroupDescription),
},
'seo-mobile': {
title: 'Mobile Friendly',
description: 'Make sure your pages are mobile friendly so users don’t have to pinch or zoom ' +
'in order to read the content pages. [Learn more](https://developers.google.com/search/mobile-sites/).',
title: str_(UIStrings.seoMobileGroupTitle),
description: str_(UIStrings.seoMobileGroupDescription),
},
'seo-content': {
title: 'Content Best Practices',
description: 'Format your HTML in a way that enables crawlers to better understand your app’s content.',
title: str_(UIStrings.seoContentGroupTitle),
description: str_(UIStrings.seoContentGroupDescription),
},
'seo-crawl': {
title: 'Crawling and Indexing',
description: 'To appear in search results, crawlers need access to your app.',
title: str_(UIStrings.seoCrawlingGroupTitle),
description: str_(UIStrings.seoCrawlingGroupDescription),
},
},
categories: {
Expand Down
24 changes: 24 additions & 0 deletions lighthouse-core/lib/i18n/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,6 +1167,30 @@
"message": "SEO",
"description": "Title of the Search Engine Optimization (SEO) category of audits. This is displayed at the top of a list of audits focused on topics related to optimizing a website for indexing by search engines. Also used as a label of a score gauge; try to limit to 20 characters."
},
"lighthouse-core/config/default-config.js | seoContentGroupDescription": {
"message": "Format your HTML in a way that enables crawlers to better understand your app’s content.",
"description": "Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website content more easily understood by search engine crawler bots."
},
"lighthouse-core/config/default-config.js | seoContentGroupTitle": {
"message": "Content Best Practices",
"description": "Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website content more easily understood by search engine crawler bots."
},
"lighthouse-core/config/default-config.js | seoCrawlingGroupDescription": {
"message": "To appear in search results, crawlers need access to your app.",
"description": "Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website accessible to search engine crawlers."
},
"lighthouse-core/config/default-config.js | seoCrawlingGroupTitle": {
"message": "Crawling and Indexing",
"description": "Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website accessible to search engine crawlers."
},
"lighthouse-core/config/default-config.js | seoMobileGroupDescription": {
"message": "Make sure your pages are mobile friendly so users don’t have to pinch or zoom in order to read the content pages. [Learn more](https://developers.google.com/search/mobile-sites/).",
"description": "Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices."
},
"lighthouse-core/config/default-config.js | seoMobileGroupTitle": {
"message": "Mobile Friendly",
"description": "Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices."
},
"lighthouse-core/lib/i18n/i18n.js | columnCacheTTL": {
"message": "Cache TTL",
"description": "Label for the TTL column in data tables, entries will be the time to live value of the cache header on a web resource"
Expand Down
18 changes: 18 additions & 0 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5417,6 +5417,24 @@
],
"lighthouse-core/config/default-config.js | a11yTablesListsVideoGroupDescription": [
"categoryGroups[a11y-tables-lists].description"
],
"lighthouse-core/config/default-config.js | seoMobileGroupTitle": [
"categoryGroups[seo-mobile].title"
],
"lighthouse-core/config/default-config.js | seoMobileGroupDescription": [
"categoryGroups[seo-mobile].description"
],
"lighthouse-core/config/default-config.js | seoContentGroupTitle": [
"categoryGroups[seo-content].title"
],
"lighthouse-core/config/default-config.js | seoContentGroupDescription": [
"categoryGroups[seo-content].description"
],
"lighthouse-core/config/default-config.js | seoCrawlingGroupTitle": [
"categoryGroups[seo-crawl].title"
],
"lighthouse-core/config/default-config.js | seoCrawlingGroupDescription": [
"categoryGroups[seo-crawl].description"
]
}
},
Expand Down