core: add node 6 support to (patched) robots-parser #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
suggested changes
Mar 22, 2018
patches/robots-parser+1.0.2.patch
Outdated
| @@ -30,7 +40,7 @@ patch-package | |||
| var rules = this._rules[userAgent] || this._rules['*'] || []; | |||
|
|
|||
| - return isPathAllowed(parsedUrl.path, rules); | |||
| + return isPathAllowed(parsedUrl.pathname + parsedUrl.search, rules); | |||
| + return isPathAllowed(getPath(parsedUrl), rules); | |||
There was a problem hiding this comment.
s/getPath/getUrlPath/
paulirish
force-pushed
the
robotsnode6fix
branch
from
50f9165
to
feeff79
Compare
|
PTAL I'm committed to making this work. Even if it hates me. 👿 This fixes:
Konrad's forthcoming PR will also handle the latter, whereas current master fails on it. Honestly, not a huge deal because the invalid URLs would have to be either A) the robots.txt resolved URL or B) the main resource URL. Both of these will always be valid so it's not a huge deal. Was just something the robots-parser tests caught. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our new patch leaves out node 6 out in cold:
https://travis-ci.org/GoogleChrome/lighthouse/jobs/357025749#L634
node 6.13 has
require('url').URLbut its a month old and no other node 6 has it.so we'll add this backwards-compat support for the rest of node 6's out there.
This PR is for branch2.x only.
Konrad has an upcoming PR to roll latest
robots-parser(which will now be node 7+ only).Audience-wise: this patch only matters for our Node 6 (>6.0.0 and <6.13.0) CLI users