Log Chrome's stderr in case of failure #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Jun 27, 2017
| @@ -237,11 +241,19 @@ export class Launcher { | |||
| }) | |||
| .catch(err => { | |||
| if (retries > 10) { | |||
| log.error('ChromeLauncher', err.message); | |||
There was a problem hiding this comment.
will this end up logging this twice?
There was a problem hiding this comment.
Yes. But since it's the most important part of that wall-of-text it seems ok. :)
|
need to |
paulirish
added a commit
to GoogleChrome/chrome-launcher
that referenced
this pull request
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve debugging of #2556, #2544, #2462 , this PR will log out the contents of Chrome's stderr.
It was only through this technique that I found that Chrome had a fatal crash when I was trying to run it in a docker container:
We'll see if this will uncover the travis flake (which I presume to be unrelated to
--no-sandbox)Also in this PR: we add the
logLeveloption to chrome-launcher.