tests(types): enable type-checking for arbitrary-equality-map-test.js - #17145
Open
Abhinavkumar-07 wants to merge 2 commits into
Open
tests(types): enable type-checking for arbitrary-equality-map-test.js#17145Abhinavkumar-07 wants to merge 2 commits into
Abhinavkumar-07 wants to merge 2 commits into
Conversation
Abhinavkumar-07
requested review from
connorjclark
and removed request for
a team
July 24, 2026 21:40
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes core/test/lib/arbitrary-equality-map-test.js from tsconfig.json's type-check exclude list (one of the files noted as needing further work before they can be type-checked).
Fixed 2 resulting TS2554 errors — both were calls to Mocha's it(title, fn, timeoutMs), whose types only declare 1–2 params. Converted to the this.timeout(ms) pattern already used elsewhere in the test suite (e.g. core/test/scenarios/api-test-pptr.js).
Verified: yarn type-check passes clean, and all 4 tests in the file still pass.