Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: support ts targets before es2022 #15189

Merged
merged 2 commits into from
Jun 22, 2023
Merged

core: support ts targets before es2022 #15189

merged 2 commits into from
Jun 22, 2023

Conversation

adamraine
Copy link
Member

Fixes #15186

It's a pretty simple fix, but the options param on Error was first added in Node 16 which is our minimum node version. If someone encounters a type error like in #15186, is that just a sign that their ts target is too old for us to support?

@adamraine adamraine requested a review from a team as a code owner June 20, 2023 19:56
@adamraine adamraine requested review from connorjclark and removed request for a team June 20, 2023 19:56
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok? As you said, it's a simple fix, so why not. Maybe add an explicit TODO to remove in LH11 or whenever, though, so it's clear that it can be removed at some point.

Sooner or later we're going to want to include other features in the es2022 lib (there's not much else in that one, but there's at least [].at()/''.at()), but since we publish types now, we could maybe make sure to align bumping tsc target versions with when we bump node version requirements so we don't catch people like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript compilation issue on lighthouse package 10.3.0
4 participants