Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(build): fix vercel deployment by adopting stricter engines grammar #13183

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

paulirish
Copy link
Member

the vercel deployments broke because of #13099 👍
image

There's no formal spec for semver constraints, but the && syntax seems to be a problem. https://jubianchi.github.io/semver-check doesnt like it and neither does the semver npm package.

image

https://github.com/npm/node-semver#range-grammar wasn't mentioned in the grammar..

after looking at those docs for a bit i saw this example:
image

so anyway... its an easy fix and the new range is parsed happily by 'semver' and vercel's thing.

image

image

@connorjclark
Copy link
Collaborator

connorjclark commented Oct 6, 2021

loose is a thing in semver which seems to ignore unknown characters (like &&...). Since ignoring && results in treating that token like a space, which is how semver apparently does logical AND, it resulted in this constraint working OK when loose === true. That's the default in yarn, which is why my manual testing switching node versions seemed to check out.

@patrickhulce patrickhulce merged commit c219a9c into master Oct 6, 2021
@patrickhulce patrickhulce deleted the enginez branch October 6, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants