misc(treemap): highlight treemap node on mouse hover table row #12483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
May 17, 2021
| @@ -78,6 +78,8 @@ class TreemapViewer { | |||
| this.viewModes; | |||
| /** @type {RenderState=} */ | |||
| this.previousRenderState; | |||
| /** @type {WeakMap<HTMLElement, LH.Treemap.Node>} */ | |||
There was a problem hiding this comment.
Out of curiosity, why a WeakMap if it's recreated with every new version of the table? To me it still signals something special is going on so be careful while reading, but it's probably actually a good default to use when you don't need to iterate and perf isn't a big concern...
There was a problem hiding this comment.
In addition to different bundle selector values re-creating the table, scrolling also recreates rows. They are all lazily rendered. So it's good that scrolling doesn't eventually result in OOM (after n months or whatever) :)
There was a problem hiding this comment.
also agree it's just a good default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #11254