tests(smoke): drop screenshot-too-big case #11428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Onnnnnnnnn second thought.... perhaps the screenshot-too-big failure happening on the PR where we change how we get a screenshot is something worth investigating......... :D /me starts looking at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to fix another smoke flake. #11341
example happened here: https://github.com/GoogleChrome/lighthouse/pull/11402/checks?check_run_id=1098415903#step:8:622
the smoketest tries creating a page that'll end up with a TOO HUGE datauri, but sometimes it's not huge enough to hit our check.
IMO constructing smoketest for this case seems unnecessary. The existing unit test seems fine to confirm the
if (screenshot.data.length > MAX_DATA_URL_SIZE)conditional works.