Make launcher the default export. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samccone
force-pushed
the
sjs/add_default_export
branch
from
c80b877 to
7e67675
Compare
This will make it so users can do ```js import chromeLauncher from 'chrome-launcher'; ``` This in some cases provides a nicer end user DX, and since it still retains the old behavior of also exporting a named export this is not a breaking change. For this reason I postulate that this is an overall win to consumers of the API. Fixes #37
samccone
force-pushed
the
sjs/add_default_export
branch
from
7e67675 to
ba483e4
Compare
paulirish
approved these changes
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it so users can do
This in some cases provides a nicer end user DX, and since it still
retains the old behavior of also exporting a named export this is not a
breaking change. For this reason I postulate that this is an overall win
to consumers of the API.
Fixes #37