feat: flag for mission control comments#27
Merged
vigneshrajsb merged 1 commit intomainfrom Jul 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a configurable feature flag defaultControlComments to control whether mission control comments are posted to pull requests. This flag provides flexibility for testing scenarios where parallel tools are being used alongside Lifecycle.
- New boolean configuration field
defaultControlComments(defaults totrue) added to control mission control comment behavior - Conditional logic implemented in the activity stream service to check the flag before posting comments
- Comprehensive test coverage added for the new feature
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/server/services/types/globalConfig.ts | Added defaultControlComments boolean field to LabelsConfig type |
| src/server/services/globalConfig.ts | Set default value of true for defaultControlComments in labels configuration |
| src/server/services/activityStream.ts | Implemented conditional logic to check flag before updating mission control comments |
| src/server/lib/utils.ts | Added isControlCommentsEnabled utility function with error handling |
| src/server/services/tests/globalConfig.test.ts | Updated test expectations to include new configuration field |
| src/server/lib/tests/utils.test.ts | Added comprehensive test coverage for isControlCommentsEnabled function |
| src/server/db/migrations/001_seed.ts | Updated database seed to include defaultControlComments: true in default configuration |
vmelikyan
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a flag to control default comment from Lifecycle -
defaultControlCommentsBy default set to
true, will create the mission control comment in the pull request. When set tofalse, stops posting mission control comments to the PRUseful when testing new versions of Lifecycle in parallel with other tools