feat: docker and command type for webhooks #18
Merged
vigneshrajsb merged 3 commits intoGoodRxOSS:mainfrom Jul 7, 2025
Merged
Conversation
feat: minor changes to webhook extensions feat: simplify job metadata remove unused api for now
webhook pod logs UI ui fixes remove file
fabd860 to
e1a673d
Compare
vmelikyan
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While
codefreshintegrated webhook is good to have, we want to have other options to be able to run webhooks.With extending webhook types to
dockerandcommandtype, we can use this run several scenarios from slack notifications to executing other CI builds as needed.Examples
Docker Type Webhook
Command Type Webhook (Simplified)
History view
Empty state
With invocations
Missing features
Pending
PS:
codefreshtype webhook is still supported and has the same schema.CODEFRESH_API_KEYenv var should be set in the worker deployment for this webhooks to work as expected