update docs from feedback and minor edits for clarity#2
Merged
vmelikyan merged 2 commits intoGoodRxOSS:mainfrom Jun 6, 2025
Merged
update docs from feedback and minor edits for clarity#2vmelikyan merged 2 commits intoGoodRxOSS:mainfrom
vmelikyan merged 2 commits intoGoodRxOSS:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refreshes documentation examples and clarifies setup steps based on feedback.
- Updated example subdomains in Mission Control docs
- Switched Helm install to
helm upgrade -iand added certificate readiness guidance - Standardized template-variable formatting, added “no spaces” note
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages/docs/tips/using-mission-control.mdx | Updated example UUID in the override section |
| src/pages/docs/setup/install-lifecycle.mdx | Replaced helm install with helm upgrade -i, added certificate check |
| src/pages/docs/features/template-variables.mdx | Clarified that service names must have no spaces |
| src/lib/static/blogcontent/blogcontent.ts | Synced blogcontent bodies with MDX changes; updated formatting in strings |
| src/lib/static/blogcontent/blogcontent.json | Updated JSON version to match MDX and TS changes |
| src/components/home/main/index.tsx | Ensured a space is rendered after “Introducing” in JSX |
Comments suppressed due to low confidence (2)
src/lib/static/blogcontent/blogcontent.ts:37
- The placeholder between the backticks is empty. Update it to show the intended format, for example
{{{<service>_internalHostname}}}.
For service-specific variables, replace `` with the actual service name.
src/lib/static/blogcontent/blogcontent.json:35
- The placeholder between the backticks is empty. Update it to show the intended format, for example
{{{<service>_internalHostname}}}.
For service-specific variables, replace `` with the actual service name.
vmelikyan
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes