Skip to content

[FFA-502] Parse width and height #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2025
Merged

[FFA-502] Parse width and height #9

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2ea825
Parse width and height
Jun 10, 2025
d6dac93
ViewPort and ViewBox are two concepts
Jun 11, 2025
17a4ce1
Add test case
Jun 11, 2025
03a5aab
Add test cases that use 100% in root node
Jun 11, 2025
eef6057
Update SVGShapeParser.swift
pacowong Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Source/Parser/SVG/SVGParserPrimitives.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,11 @@ public class SVGHelper: NSObject {
let height = SVGLengthParser.yAxis.double(string: nums[3], context: context) {
return CGRect(x: x, y: y, width: width, height: height)
}
} else if let widthAttr = attributes[ignoreCase: "width"],
let heightAttr = attributes[ignoreCase: "height"],
let width = SVGLengthParser.xAxis.double(string: widthAttr, context: context),
let height = SVGLengthParser.yAxis.double(string: heightAttr, context: context) {
Copy link
Collaborator

@khoi khoi Jun 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVGLengthParser parse % props to absolute values based on the parent width, height (fetched from context).

I wonder what would be the values parsed here for width and height, can u please check?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to the results in viewport-02.ref, if the % is used in the viewport attribute, the size will be 100x100.

return CGRect(x: 0.0, y: 0.0, width: width, height: height)
}
return nil
}
Expand Down
Loading