Improve DX ergonomic #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace script-test-cases.sh with Makefile targets - Add help system and test running capabilities - Preserve existing test case generation logic for SVG 1.1 and 1.2 specs - Consolidate build and test operations into standard Make interface
- Combine separate Linux and macOS test jobs into single matrix job - Use dynamic OS naming and runner configuration via matrix variables - Update test command to use Makefile instead of direct Swift command - Maintain same test coverage while reducing workflow complexity
- Remove Exyte branding and company-specific content - Add attribution to original exyte/SVGView repository - Document Goodnotes-specific customizations and requirements - Add development section with Makefile usage instructions - Simplify project overview and remove platform badges
- Fix YAML formatting and indentation consistency - Filter Linux tests to CoreGraphicsPolyfillTests only - Remove trailing whitespace and normalize spacing
khoi
commented
May 28, 2025
| ## To add a new SVG test: | ||
| - Update `cli.swift` to include the svg file path | ||
| - `make generate-test-cases` to generate the unit test files | ||
| - `make update-references-snapshots` to update the .ref snapshots. |
- Add fallback CLI implementation for non-macOS platforms - Display clear error message when attempting to run on unsupported systems - Maintain existing functionality on macOS while preventing execution elsewhere
pacowong
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the ergonomic of development: