Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) #1068 new dashboard card hanukka bonus #1077

Merged
merged 3 commits into from
Dec 19, 2019
Merged

(Feature) #1068 new dashboard card hanukka bonus #1077

merged 3 commits into from
Dec 19, 2019

Conversation

yaroslav-fedyshyn-nordwhale
Copy link
Contributor

@yaroslav-fedyshyn-nordwhale yaroslav-fedyshyn-nordwhale commented Dec 18, 2019 •
edited
Loading

Description

Create hanukaBonusStartsMessage object which represents structured data for feed card. Crete method which called from startSystemFeed on app start. Add styles and images required for the feed card. Also added test for new feed card.

About #1068

How Has This Been Tested?

You need to set the current date period for Hanuka bonus env vars.
Then start the Dapp server and go to the dashboard.
The new feed card 'Hanuka bonus info' should appear.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request ( for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Screenshots:

Browser Simulators
Card br1 sim1
Modal br2 sim2

LiavGut
LiavGut suggested changes Dec 19, 2019
View reviewed changes
Copy link

@LiavGut LiavGut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is that a bug in the visual?
    71096238-9e310a80-21b6-11ea-906b-66c2b7e93499

  2. Title: Please break the line after "GoodDollars"

  3. Change text: "45" to "44"

@yaroslav-fedyshyn-nordwhale
Copy link
Contributor Author

@LiavGut Fixed. See Changes:
1

@sirpy sirpy merged commit 2c16797 into master Dec 19, 2019
@serdiukov-o-nordwhale serdiukov-o-nordwhale deleted the 1068-New_Dashboard_card_Hanukka_Bonus branch July 8, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiavGut LiavGut LiavGut approved these changes

@sirpy sirpy sirpy approved these changes

@AlexeyKosinski AlexeyKosinski Awaiting requested review from AlexeyKosinski

@Nordwhale Nordwhale Awaiting requested review from Nordwhale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaroslav-fedyshyn-nordwhale @sirpy @LiavGut