style: resolve type and style requests from #562 #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KANAjetzt
changed the title
KANAjetzt
reviewed
Jun 29, 2025
There was a problem hiding this comment.
One other small thing, it is helpful to create a separate feature branch for your PRs, it makes it easier for the reviewers to check the branch out. If the PR is using the dev branch directly, the reviewer will most likely have to delete their dev branch first.
Thanks! 😁
Sorry about any issue my PRing shenanigans caused, I'll keep this in mind from now on! |
doesn't error when ModLoaderStore isn't initialized
Co-authored-by: KANAjetzt <41547570+KANAjetzt@users.noreply.github.com>
KANAjetzt
approved these changes
Jul 8, 2025
KANAjetzt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny PR (+10-10) which applies the changes outlined by @KANAjetzt in #562
Auto merge was turned on for the PR, and the changes of #562 were merged before I could resolve the nit picks. This PR resolves those.