-
Notifications
You must be signed in to change notification settings - Fork 41
test: 🧪 added tests for .process_script()
#476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bb2cb2c
to
9289597
Compare
3401480
to
c556201
Compare
c556201
to
f73e930
Compare
92c5f02
to
925acc0
Compare
and did some reformatting
4f1bd88
to
bbd0dbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. this must be the funniest code in the whole repo.
i think the long term goal is to test all the cases separately, each with their own script. that way we'll know exactly what failed at a glance. but finding which one causes issues is mostly possible already and we also get tests for things like duplicate names and just multiple variables and functions in the same file in general.
one small addition would be subclasses to the uncovered cases
This adds 3 test scripts (
test_script_A / B / C.gd
) with their expected results (test_script_A / B/ C_processed.gd
) to validate the functionality of_ModLoaderModHookPreProcessor.process_script()
.Note
The
class_name
in the_processed.gd
scripts must be commented out to avoid the "hiding global class" error.Test run is broken until #495 is merged or
func please_stop
is removed from test script C.TODO
func func_name\\n#comment()
#494Dev Notes