Skip to content

test: 🧪 Ported tests to 4.x #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 22, 2024
Merged

test: 🧪 Ported tests to 4.x #434

merged 8 commits into from
Nov 22, 2024

Conversation

@KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Nov 15, 2024 •
edited
Loading

Ported the test workflow from the 3.x branch

Notable Changes

  • Updated the GUT version to the latest release v9.3.0
  • Updated the Godot version:
    • Currently running tests only on 4.3
    • No separate headless version, now using --headless instead
    • Global class data is no longer stored in the project file, requiring a --import run before tests are executed

To-Do

  • Run tests on additional Godot versions:
    • 4.2.2
    • 4.1.4
  • Resolve two currently failing tests:
    • test_match_func_with_whitespace
    • test_handle_script_extensions

@KANAjetzt KANAjetzt self-assigned this Nov 19, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Nov 20, 2024
@KANAjetzt KANAjetzt force-pushed the test_runner branch 2 times, most recently from 808adde to 0102cc2 Compare November 20, 2024 16:23
@KANAjetzt KANAjetzt marked this pull request as ready for review November 21, 2024 08:45
@KANAjetzt
fix: 🔥 removed start and end index test
ba54801
@KANAjetzt
fix: 🐛 don't apply script extensions
71f307e 
`install_script_extension` is commented out to prevent interference with the script extension sorting test. Applying script extensions causes the `.get_base_script()` call in `_ModLoaderScriptExtension.InheritanceSorting` to return an incorrect value.
@KANAjetzt KANAjetzt requested a review from Qubus0 November 21, 2024 18:03
Qubus0
Qubus0 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can clean up some of the "expected x was y instead" extra messages we added since that is logged anyway.

otherwise nice! thank you

This was referenced Nov 22, 2024
Open
Open
@KANAjetzt KANAjetzt added this pull request to the merge queue Nov 22, 2024
Merged via the queue into GodotModding:4.x with commit 6a3d76e Nov 22, 2024
2 checks passed
@KANAjetzt KANAjetzt deleted the test_runner branch November 22, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

Assignees

@KANAjetzt KANAjetzt

Labels

4.x test

Projects

None yet

Milestone

4.x - 7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@KANAjetzt @Qubus0