Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement a cache of script inheritence #314

Merged
merged 5 commits into from
Jul 2, 2023
Merged

feat: Implement a cache of script inheritence #314

merged 5 commits into from
Jul 2, 2023

Conversation

boardengineer
Copy link
Contributor

@boardengineer boardengineer commented Jun 30, 2023 •
edited
Loading

There was a clobbered importance order that is no longer being called cosmetically

the Inheritance stacks are now being saved so they don't have to be recalced again on each iteration, this saves the majority of the sorting time

A ScriptExtensionData type has been removed since it was only used to keep attributes together through the sort and a bit of unnecessary work was done to maintain the type.


closes
#311

@boardengineer
Implement a cache of script inheritence
9cd1415 
There was a clobbered importance order that is no longer being called cosmetically

the Inheritance stacks are now being saved so they don't have to be recalced again on each iteration, this saves the majority of the sorting time
@otDan otDan changed the title Implement a cache of script inheritence feat: Implement a cache of script inheritence Jun 30, 2023
@KANAjetzt KANAjetzt added enhancement New feature or request performance labels Jul 1, 2023
@KANAjetzt KANAjetzt added this to the v6.1.0 milestone Jul 1, 2023
@KANAjetzt KANAjetzt requested a review from a team July 1, 2023 10:03
KANAjetzt
KANAjetzt reviewed Jul 1, 2023
View reviewed changes
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!
I tested it with my 18 mods in Brotato, and the difference is like night and day.
( And still works as expected 👀 )

addons/mod_loader/internal/script_extension.gd Outdated Show resolved Hide resolved
addons/mod_loader/internal/script_extension.gd Outdated Show resolved Hide resolved
addons/mod_loader/internal/script_extension.gd Outdated Show resolved Hide resolved
addons/mod_loader/internal/script_extension.gd Outdated Show resolved Hide resolved
addons/mod_loader/resources/script_extension_data.gd Show resolved Hide resolved
@boardengineer
Add Comments
6f45dd2 
Comments describing the sorting process and artifcats
@boardengineer
Tiny Style Change
b0f59a7
@boardengineer boardengineer marked this pull request as draft July 1, 2023 15:26
@boardengineer boardengineer marked this pull request as ready for review July 1, 2023 16:33
KANAjetzt
KANAjetzt approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks again for your help. Feel free to merge.

@boardengineer boardengineer added this pull request to the merge queue Jul 2, 2023
Merged via the queue into GodotModding:development with commit 8f1b410 Jul 2, 2023
@KANAjetzt KANAjetzt mentioned this pull request Jul 3, 2023
Closed
@KANAjetzt KANAjetzt modified the milestones: v6.1.0, v6.0.3 Jul 3, 2023
@KANAjetzt KANAjetzt mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KANAjetzt KANAjetzt KANAjetzt approved these changes

Assignees

@boardengineer boardengineer

Labels
enhancement New feature or request performance
Projects
None yet
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boardengineer @KANAjetzt