Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest key validation to match Thunderstore requirements #27

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Update manifest key validation to match Thunderstore requirements #27

merged 4 commits into from
Jan 15, 2023

Conversation

ithinkandicode
Copy link
Collaborator

Changes:

  • Updates the list of required manifest.json keys, to match the requirements of Thunderstore (see issue / Thunderstore docs)
  • Logging: Puts every missing key onto its own file, improving readability
  • Logging: Fixes a code error where the missing keys array wasn't cleared, causing missing keys to be duplicated in the logs

Preview:

manifest-missing-fields--full

Related:

otDan
otDan requested changes Jan 15, 2023
View reviewed changes
Copy link
Member

@otDan otDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should still keep the example as a generic manifest and not the invasion one

@ithinkandicode
Copy link
Collaborator Author

This probably should still keep the example as a generic manifest and not the invasion one

Done!

otDan
otDan approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@otDan otDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@otDan otDan merged commit db1adf9 into GodotModding:main Jan 15, 2023
@ithinkandicode ithinkandicode changed the title Update manifest key validation to match Thunderstore requirements 3.0.0 - Update manifest key validation to match Thunderstore requirements Jan 15, 2023
@ithinkandicode ithinkandicode changed the title 3.0.0 - Update manifest key validation to match Thunderstore requirements Update manifest key validation to match Thunderstore requirements Jan 15, 2023
@ithinkandicode ithinkandicode mentioned this pull request Jan 15, 2023
Merged
otDan pushed a commit that referenced this pull request Jan 15, 2023
@ithinkandicode
Fix manifest keys const name error in PR #27 (#29)
7dc0052 
* fix manifest keys const not being renamed in a previous commit
This was referenced Jan 15, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otDan otDan otDan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ithinkandicode @otDan