fix: 🐛 self setup chicken and egg problem #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ModLoader self setup script uses util function from ModLoaderUtils in GodotModding#172 ModLoaderStore was introduced into utility functions that where used by the self setup. Because the setup is run before the ModLoaderStore is initialized the setup was stuck in an infinite loop. To fix that `get_modloader_store()` was added and is now used in `_get_verbosity()`, `get_path_to_mods()` and `get_path_to_configs()`. Also updated the the autoload index check in the `_init()` of *mod_loader_setup.gd*. closes GodotModding#200
Qubus0
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #172 the ModLoaderUtils utility functions were updated to use the ModLoaderStore singleton.
However, this caused an issue with the self-setup script, as the setup was getting stuck in an infinite loop due to the
ModLoaderStorenot being initialized yet.To resolve this issue,
get_modloader_store()was added to mod_loader_utils.gd, which returns a reference to theModLoaderStoresingleton if it exists ornullotherwise.This functions use it now:
_get_verbosity()get_path_to_mods()get_path_to_configs()Additionally, the
autoload indexcheck in the_init()function of mod_loader_setup.gd was updated to check for the right indexes ofModLoaderandModLoaderStore.Tested with and without
--setup-create-override-cfg.closes #200