Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Added optional dependencies #188

Merged

Conversation

KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Mar 26, 2023

Added new loop that iterates through each mod in mod_data and runs _check_dependencies() with a new is_required flag set to false. This flag is used to determine the dependency array to use and if a mod is still loaded if the dependency is missing.

closes #122

Added new loop that iterates through each mod in `mod_data` and runs `_check_dependencies()` with a new `is_required` flag set to false. This flag is used to determine the dependency array to use and if a mod is still loaded if the depdendency is missing.
@KANAjetzt KANAjetzt added the enhancement New feature or request label Mar 26, 2023
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Mar 26, 2023
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice stuff

addons/mod_loader/classes/mod_manifest.gd Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KANAjetzt KANAjetzt added this pull request to the merge queue Mar 26, 2023
Merged via the queue into GodotModding:development with commit ea7e538 Mar 26, 2023
@KANAjetzt KANAjetzt deleted the feat_optional_dependencies branch March 26, 2023 19:00
@KANAjetzt
Copy link
Member Author

this worked towards #186

@KANAjetzt KANAjetzt mentioned this pull request Jun 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants