-
Notifications
You must be signed in to change notification settings - Fork 37
feat: ✨ ML Options: Add the groundwork for loading custom options #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ ML Options: Add the groundwork for loading custom options #145
Conversation
Neat and definitely more user friendly than all the flags. We might want to integrate the flags with the options system though - parse them in the ModLoader I don't think we need all of those examples, the options are pretty self-explanatory, especially if we use export hints like this for dictionaries |
@Qubus0 The examples aren't to help people understand the options, they're for quickly applying options without affecting your current settings:
So they basically act like profiles. That's why options_current.tres exists, since otherwise all your options would be stored in a single resource, with no way to quickly change option profiles. I guess it was the being called |
@Qubus0 Turns out that renaming them to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff, small remarks, overall approved!
c4c3bc3
to
c517b8c
Compare
All review issues have been resolved, thanks for the review @Qubus0 :) |
Adds the ability to manage various ModLoader options through Godot's own GUI.
I've set this up so that you can quickly change the options profile you want to use. There's a file called options_current.tres, which determines the options resource that's currently being used. I've provided a few other profiles too.
I've put all the options stuff in its own directory as there's quite a few files.
Todo
enable_mods
option, as I want to get feedback from you guys before this proceeds further. So the other options still need to be integrated. But that would be better in a subsequent PR, so that this one remains focused on just adding the groundwork.Notes
Docs: https://github.com/GodotModding/godot-mod-loader/wiki/Upcoming-Features#options
Related: