Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Config JSON: Swap status codes 1 and 2 (closes #131) #137

Conversation

ithinkandicode
Copy link
Collaborator

Swaps the status codes 1 and 2 around, so that a valid code is always >= 1. Also has a very minor presentation edit for the comments on the enums.

Closes #131:

@ithinkandicode ithinkandicode added the validation Feature to make things safe and predictable label Feb 26, 2023
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically breaking

@ithinkandicode
Copy link
Collaborator Author

@Qubus0 Good point. I've created a draft release as a placeholder, so that when we publish the next release we'll remember about this :)

image

@ithinkandicode ithinkandicode merged commit 97de3ff into GodotModding:development Feb 26, 2023
@ithinkandicode ithinkandicode linked an issue Feb 27, 2023 that may be closed by this pull request
@ithinkandicode ithinkandicode deleted the config-json-swap-status-1-2 branch February 28, 2023 22:46
@ithinkandicode ithinkandicode changed the title Config JSON: Swap status codes 1 and 2 (closes #131) feat: ✨ Config JSON: Swap status codes 1 and 2 (closes #131) Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation Feature to make things safe and predictable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config JSON: Swap status 1 and 2
2 participants