Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions for dependencies #18

Closed
KANAjetzt opened this issue Jan 6, 2023 · 1 comment
Closed

Versions for dependencies #18

KANAjetzt opened this issue Jan 6, 2023 · 1 comment
Labels
validation Feature to make things safe and predictable

Comments

@KANAjetzt
Copy link
Member

KANAjetzt commented Jan 6, 2023

Darkly77 — Today at 04:39
Should we start using versions for dependencies? Eg.

"dependencies": [
    {
        "name": "Dami-ContentLoader",
        "version": "2.0.0"
    },
    {
        "name": "Darkly77-BFX",
        "version": "1.0.0"
    }
],

Image
We'd need to use the semver compare approach I mentioned in this issue:
#13
Only issue is, all ModLoader mods would have to use semver -- ie x.y.z ( major.minor.patch) -- for it to work correctly
which might be too strict
though we could probably account for major.minor, as the .patch version in that case can be presumed to be .0
same with minor version actually

@ithinkandicode
Copy link
Collaborator

ithinkandicode commented Jan 29, 2023

I'm gonna close this. The dependency checks we have now are fine, and I think implementing this adds a fair bit of complexity that can be better handled by managers like Thunderstore.

EDIT: See continued discussion in #129:

@ithinkandicode ithinkandicode added the validation Feature to make things safe and predictable label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation Feature to make things safe and predictable
Projects
None yet
Development

No branches or pull requests

2 participants