Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required ModLoader version to manifest.json #13

Closed
1 of 3 tasks
ithinkandicode opened this issue Jan 5, 2023 · 1 comment
Closed
1 of 3 tasks

Add required ModLoader version to manifest.json #13

ithinkandicode opened this issue Jan 5, 2023 · 1 comment
Labels
validation Feature to make things safe and predictable

Comments

@ithinkandicode
Copy link
Collaborator

ithinkandicode commented Jan 5, 2023

Suggestion: Add a required setting in _meta.json to set the required version of ModLoader.

Requirements:

  • 1 - Add a key to meta.json that specifies the required version of ModLoader.
  • 2 - Add support for this to ModLoader: If ModLoader's version is below the required version, don't load the mod.
  • 3 - Add a const to ModLoader for its current version, eg const MODLOADER_VERSION = "2.0.0"

Since we're using a semantic version string for the version, we will need a custom compare func to check if the ModLoader version matches or is below the mod's specified version.

If it's below, we can check the major versions based on semantic versioning (major.minor.patch, eg. 2.1.16). For example, a mod that requires ModLoader v2.1.0 should still work in v2.2.0, but won't work in v3.0.0.

@ithinkandicode ithinkandicode changed the title Add required ModLoader version (meta.json) [meta.json]Add required ModLoader version Jan 7, 2023
@ithinkandicode ithinkandicode changed the title [meta.json]Add required ModLoader version [meta.json] Add required ModLoader version Jan 7, 2023
@ithinkandicode ithinkandicode changed the title [meta.json] Add required ModLoader version [manifest] Add required ModLoader version Jan 15, 2023
@ithinkandicode ithinkandicode changed the title [manifest] Add required ModLoader version Add required ModLoader version to manifest.json Jan 15, 2023
@ithinkandicode
Copy link
Collaborator Author

Task 1 was done in #40

@ithinkandicode ithinkandicode added the validation Feature to make things safe and predictable label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation Feature to make things safe and predictable
Projects
None yet
Development

No branches or pull requests

1 participant