Clarify consensus error message (MystenLabs#1937)

Clarify consensus error message
GodfatherMe · May 13, 2022 · 50694cc · 50694cc
1 parent 84f434b
commit 50694cc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/sui_core/src/consensus_adapter.rs b/sui_core/src/consensus_adapter.rs
@@ -144,7 +144,8 @@ impl ConsensusAdapter {
         };
 
         resp.and_then(|r| {
-            bincode::deserialize(&r).map_err(|e| SuiError::ConsensusConnectionBroken(e.to_string()))
+            bincode::deserialize(&r)
+                .map_err(|e| SuiError::ConsensusNarwhalSerializationError(e.to_string()))
         })
     }
 }

diff --git a/sui_core/tests/staged/sui.yaml b/sui_core/tests/staged/sui.yaml
@@ -582,15 +582,18 @@ SuiError:
     99:
       ListenerCapacityExceeded: UNIT
     100:
+      ConsensusNarwhalSerializationError:
+        NEWTYPE: STR
+    101:
       SignatureSeedInvalidLength:
         NEWTYPE: U64
-    101:
+    102:
       HkdfError:
         NEWTYPE: STR
-    102:
+    103:
       SignatureKeyGenError:
         NEWTYPE: STR
-    103:
+    104:
       RpcError:
         NEWTYPE: STR
 TransactionDigest:

diff --git a/sui_types/src/error.rs b/sui_types/src/error.rs
@@ -318,6 +318,8 @@ pub enum SuiError {
     SharedObjectLockingFailure(String),
     #[error("Consensus listener is out of capacity")]
     ListenerCapacityExceeded,
+    #[error("Failed to  serialize/deserialize Narwhal message: {0}")]
+    ConsensusNarwhalSerializationError(String),
 
     // Cryptography errors.
     #[error("Signature seed invalid length, input byte size was: {0}")]