Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 examples for Vector #239

Merged
merged 14 commits into from
Oct 28, 2024
Merged

Conversation

EmilyBourne
Copy link
Contributor

@EmilyBourne EmilyBourne commented Oct 3, 2024

Add Vector examples for version 2 of GFTL. Also fix a typos in the documentation.
Fixes #238

Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Copy link
Member

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good - thank you for putting so much effort into this. And my apologies for forgetting to look at this over the weekend.

I've requested a few minor changes - see the inline comments.

I'm wondering if the next step is to add some more in-source documentation describing just what each example is doing. "This example creates a container of type ... and then adds 3 elements and prints the 2nd element." Something like that.

And then maybe a README.md file per directory that gives a one sentence summary of each example?

@EmilyBourne
Copy link
Contributor Author

It looks good - thank you for putting so much effort into this. And my apologies for forgetting to look at this over the weekend.

No problem. Happy to help :)

I'm wondering if the next step is to add some more in-source documentation describing just what each example is doing. "This example creates a container of type ... and then adds 3 elements and prints the 2nd element." Something like that.

I have added some comments to the examples

And then maybe a README.md file per directory that gives a one sentence summary of each example?

That sounds like a good idea. I have added a basic README here: 9bbb883

@tclune
Copy link
Member

tclune commented Oct 15, 2024

That sounds like a good idea. I have added a basic README here: 9bbb883

Looks good.

@tclune tclune merged commit 08ffdf2 into Goddard-Fortran-Ecosystem:main Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2] Vector initialisation from array of elements
2 participants