-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
race-condition-pointers.go örneği, atomic kullanılarak fix edildi #12
Open
akcauser
wants to merge
3
commits into
GoTurkiye:main
Choose a base branch
from
akcauser:race-condition-pointers-fix-with-atomic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
...utines/race-condition-pointers-fix-with-atomic/race-condition-pointers-fix-with-atomic.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
package main | ||
|
||
import ( | ||
"fmt" | ||
"sync" | ||
"sync/atomic" | ||
) | ||
|
||
type RaceTest struct { | ||
Val int32 | ||
} | ||
|
||
func main() { | ||
raceTest := &RaceTest{} | ||
|
||
wg := &sync.WaitGroup{} | ||
wg.Add(10000) | ||
|
||
for i:=0; i<10000; i++ { | ||
go increment(raceTest, wg) | ||
} | ||
|
||
wg.Wait() | ||
|
||
fmt.Println(raceTest) | ||
} | ||
|
||
func increment(rt *RaceTest, wg *sync.WaitGroup) { | ||
atomic.AddInt32(&rt.Val, 1) | ||
wg.Done() | ||
} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atomic ornegi guzel olmus, aynisini farkli baska bir fonksiyonda mutex ile ornegini yapip aralarinda benchmark uyguladigimiz bir test eklesek nasil olurdu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Çok güzel bir örnek olur aslında, ikisi arasındaki performans farkını görmüş oluruz hem,
#7 şuradaki pr da mutex ile çözümü var. Her ikisi merge edildiğinde yeni bir branch üzerinden benchmark testlerini yazarsak temiz olur diye düşünüyorum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 istersen o PR'daki commiti cherry-pick ile bu PR'a tasiyip islemleri buradan da devam ettirebiliriz tek bir .go dosyasi uzerinden. ne dusunursun?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selamlar, ilgili pr merge edildi, buradaki süreci ilerletebilirsiniz.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
102-concurrency/goroutines altında bir dizin oluşturalım o zaman, #7 deki merge ile gelen mutex lock çözümünü içerisine ekleyip benchmark testleri için tek bir dosya açarız. İlk söylediğin gibi tek bir dosyada 2 farklı metodu da eklediğimizde güzel olacaktır. Ne dersin?
En sonda dizinin görüntüsü şu şekilde olacak.