Added fix(recorder): replace colons in filenames to ensure Windows compatibilty and runs across other platforms as well #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a failure in the Ubuntu tests |
So i checked your bash script, you have hard coded the filename file -E "20200319000716_192.168.38.1:20989-192.168.38.1:3389.pyrdp", the whole purpose of this line is to remove this : colon so it can run across any platform, i have ran it on my kali linux, it worked fine on it. |
|
No worries, if you could just update the line on the test so it passes it'd be enough! |
|
I have fixed it, you can check now |
|
let me test it on my ubuntu |
|
alright now the integration test is working on my ubuntu. there was one more file where the colon was getting generated now its fixed @Res260 you can run the workflow again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Make filenames compatible with Windows for pyrdp-convert
This PR fixes an issue where PyRDP would crash on Windows due to invalid characters (colons) in filenames generated for recordings.
Colons (
:) are replaced with underscores (_) to ensure the filenames are valid on Windows systems.Tested on Windows 11 with Python 3.13 Recording now works as expected.