use PACKER_CACHE_DIR env var if already set #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It works 👍 |
Collaborator
|
Build failed because Python3.3 doesn't support enum and a dep of pylint uses it. I'll try your fix tomorrow and update this PR. |
Contributor
|
Resubmitted the job. Hopefully, it got fixed by upstream in the meantime. |
Contributor
|
It didn't fix it. After some googling, I found out that pylint no longer supports Python 3.3. Python 3.3 has been end of life in 2017 and even Ubuntu 14.04 runs with Python 3.4 by default. I'm going to fix this in a PR then resubmit the job here. Edit: added the link |
Contributor
|
Merged. I ignored failure related to Python 3.3 since it was fixed with #101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks for the value of
PACKER_CACHE_DIRfirst, and then defaults toDIRS.user_cache_dir.Solves #99
You can review it, i'm testing it right now.