Auto-Migration #406
Open
Auto-Migration #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorquinDevlar
approved these changes
Jun 22, 2025
There was a problem hiding this comment.
I think is a good idea, although I don't see any kind of backup being taken before migration is done. If migration fails, there is seemingly no way to get back to the previous version.
Also, I don't see any validation for loading zone config's, and potentially adding missing ones before migration. Just an observation.
Comment on lines
+51
to
+53
| func (v Version) IsOlderThan(other Version) bool { | ||
| return v.Compare(other) <= Older | ||
| } |
There was a problem hiding this comment.
Wouldn't this consider equal versions as older than each other? I would think this should be just < Older
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This defines a basic process for including auto-correcting/updating of datafiles etc. when users upgrade to a new binary version.
Changes