Copyover (Hot-reload) for GoMud #405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation for - API - Combat - Quests - Economy - Pets - Spells - Modules
…auto connect players back to their state - Implemented copyover command for admins to restart server without disconnecting players - Preserved TCP connections across process restart using file descriptor inheritance - Added automatic build integration - rebuilds server before copyover - Saved all player states and positions before restart - Created templated messages for all copyover phases with ANSI color support - Added build number tracking to verify successful updates - Skipped login commands when recovering from copyover - Handled connection recovery with proper user session restoration The copyover system allows live code updates to be deployed without disrupting active players. Currently supports Unix-like systems (Linux, macOS). - `copyover now` - Immediate restart - `copyover [seconds]` - Restart with countdown - `copyover test` - Test system readiness
- Added event queue serialization/deserialization using reflection to preserve pending events - Implemented JavaScript VM state tracking for script preservation across copyovers - Added active mutator preservation to maintain room states during hot-reload - Created pet/charm relationship persistence to keep user-mob connections intact - Implemented quest timer preservation to maintain quest progress across restarts - Added spell cast state preservation for in-progress spell casting - Fixed state machine transitions to properly handle idle->recovering state - Resolved import cycles by centralizing copyover logic in dedicated package - Fixed network listener ordering to ensure consistent FD assignment - Consolidated all subsystem integrations into single integrations.go file - Added comprehensive error handling and logging throughout the system - Cleaned up codebase by removing redundant code and fixing naming inconsistencies The copyover system now preserves all critical game state during hot-reloads, allowing seamless server updates without disrupting player experience.
- Fixed zombie user reconnection after copyover by correcting userId variable in LoginUser - Removed special prompt priority handling that caused prompts to appear before room text - Added proper telnet negotiation commands for recovered connections (WILL ECHO, WONT LINE_MODE, DO NAWS) - Improved zombie connection cleanup in RemoveZombieConnection to prevent stale mappings - Increased worker startup delay to 2 seconds to ensure event system is ready - Fixed copyover_recovery flag timing to not clear prematurely The copyover system now correctly displays prompts after room descriptions and allows users to reconnect if they disconnect post-copyover.
Integrate copyover with the global mutex (util.LockMud/UnlockMud) to ensure atomic state capture and prevent race conditions during hot reload. Key changes: - Execute copyover outside event loop to avoid deadlock with mutex - Separate build phase from critical copyover operations to minimize lock time - Add deferred recovery queue to eliminate 2-second sleep workaround - Ensure all template messages display correctly for immediate copyover The mutex integration provides: - Guaranteed consistent state capture (no mid-update snapshots) - Protection against concurrent modifications during copyover - Proper synchronization with combat and other game systems - Atomic save operations for all player data Performance impact is minimal as the build phase (longest operation) now runs outside the mutex lock, reducing game freeze from ~5s to ~2s.
- Reduce state machine from 10 states to 5 (Idle, Scheduled, Preparing, Executing, Recovering) - Replace polling-based scheduling with timer-based approach - Consolidate multiple entry points into single Copyover() method with options - Fix mutex deadlock by using event system for copyover initiation - Fix state file creation and persistence issues - Fix connection recovery by preserving isRecovering flag until completion - Move build phase before mutex acquisition to reduce game freeze time - Switch from full rebuilds to incremental builds during copyover - Fix executable name resolution (use go-mud-server instead of WillowdaleMUD) - Add comprehensive logging for debugging copyover flow - Remove duplicate progress tracking mechanisms - Eliminate dual mutex pattern in favor of single mutex approach - Update world.go to handle pending copyover via event system - Add missing copyover-cancelled.template files - Fix recovery completion timing to ensure connections are restored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a copyover (hot-reload) system for the GoMud server that preserves game state during server restarts.
Changes
Technical Details
Subsystems
Module System