Skip to content

fix bad schema definition #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix bad schema definition #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 20 additions & 21 deletions apps/contacts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,7 +1583,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ContactsByIdSuccessfulResponseDto"

Check warning on line 1586 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
}
}
Expand Down Expand Up @@ -1674,7 +1674,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/UpdateContactsSuccessfulResponseDto"

Check warning on line 1677 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
}
}
Expand Down Expand Up @@ -1807,7 +1807,7 @@
"post": {
"operationId": "upsert-contact",
"summary": "Upsert Contact",
"description": "Please find the list of acceptable values for the `country` field <a href=\"https://highlevel.stoplight.io/docs/integrations/ZG9jOjI4MzUzNDIy-country-list\" target=\"_blank\">here</a><br/><br/>The Upsert API will adhere to the configuration defined under the “Allow Duplicate Contact” setting at the Location level. If the setting is configured to check both Email and Phone, the API will attempt to identify an existing contact based on the priority sequence specified in the setting, and will create or update the contact accordingly.<br/><br/>If two separate contacts already exist—one with the same email and another with the same phone—and an upsert request includes both the email and phone, the API will update the contact that matches the first field in the configured sequence, and ignore the second field to prevent duplication.",
"description": "Please find the list of acceptable values for the `country` field <a href=\"https://highlevel.stoplight.io/docs/integrations/ZG9jOjI4MzUzNDIy-country-list\" target=\"_blank\">here</a><br/><br/>The Upsert API will adhere to the configuration defined under the \u201cAllow Duplicate Contact\u201d setting at the Location level. If the setting is configured to check both Email and Phone, the API will attempt to identify an existing contact based on the priority sequence specified in the setting, and will create or update the contact accordingly.<br/><br/>If two separate contacts already exist\u2014one with the same email and another with the same phone\u2014and an upsert request includes both the email and phone, the API will update the contact that matches the first field in the configured sequence, and ignore the second field to prevent duplication.",
"parameters": [
{
"name": "Version",
Expand Down Expand Up @@ -1838,7 +1838,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/UpsertContactsSuccessfulResponseDto"

Check warning on line 1841 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
}
}
Expand Down Expand Up @@ -1957,7 +1957,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ContactsSearchSuccessfulResponseDto"

Check warning on line 1960 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
}
}
Expand Down Expand Up @@ -2828,7 +2828,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ContactsSearchSuccessfulResponseDto"

Check warning on line 2831 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
}
}
Expand Down Expand Up @@ -3043,16 +3043,16 @@
"type": "string",
"example": "1a2b3c4d5e6f7g8h9i0j"
},
"pipeline_id": {
"pipelineId": {
"type": "string",
"example": "pipeline123"
},
"pipeline_stage_id": {
"pipelineStageId": {
"type": "string",
"example": "stage456"
},
"monetary_value": {
"monetaryValue": {
"type": "number",

Check warning on line 3055 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[LOW] Numeric Schema Without Minimum (v3) 

Details:
Numeric schema (type set to 'integer' or 'number') should have 'minimum' defined.

Recommendation:
Numeric schema should have 'minimum' defined

Check warning on line 3055 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[LOW] Numeric Schema Without Format (v3) 

Details:
Numeric schema (type set to 'integer' or 'number') should have 'format' defined.

Recommendation:
Numeric schema should have 'format' defined

Check warning on line 3055 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[LOW] Numeric Schema Without Maximum (v3) 

Details:
Numeric schema (type set to 'integer' or 'number') should have 'maximum' defined.

Recommendation:
Numeric schema should have 'maximum' defined
"example": 10000
},
"status": {
Expand Down Expand Up @@ -3754,7 +3754,8 @@
"properties": {
"url": {
"type": "string",
"example": "Trigger Link"
"example": "Trigger Link",
"nullable": true
},
"campaign": {
"type": "string",
Expand Down Expand Up @@ -3787,7 +3788,7 @@
},
"gclid": {
"type": "string",
"example": "CjOKCQjwnNyUBhCZARISAI9AYIFtNnIcWcYGIOQINz_ZoFI5SSLRRugSoPZoiEu27IZBY£1-MAIWmEaAo2VEALW_WCB",
"example": "CjOKCQjwnNyUBhCZARISAI9AYIFtNnIcWcYGIOQINz_ZoFI5SSLRRugSoPZoiEu27IZBY\u00a31-MAIWmEaAo2VEALW_WCB",
"nullable": true
},
"msclikid": {
Expand Down Expand Up @@ -3833,9 +3834,7 @@
"nullable": true
}
},
"required": [
"url"
]
"required": []

Check warning on line 3837 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
},
"GetContectByIdSchema": {
"type": "object",
Expand Down Expand Up @@ -3982,10 +3981,10 @@
"example": "641c094001436dbc2081e642"
},
"attributionSource": {
"$ref": "#/components/schemas/AttributionSource"

Check warning on line 3984 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
},
"lastAttributionSource": {
"$ref": "#/components/schemas/AttributionSource"

Check warning on line 3987 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
},
"visitorId": {
"type": "string",
Expand All @@ -3998,7 +3997,7 @@
"type": "object",
"properties": {
"contact": {
"$ref": "#/components/schemas/GetContectByIdSchema"

Check warning on line 4000 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
}
},
Expand All @@ -4013,7 +4012,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"example": [
"test",
"test2"
Expand All @@ -4039,7 +4038,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"type": "object",
"example": {}
}
Expand All @@ -4061,7 +4060,7 @@
"example": "my_custom_field",
"description": "Pass either `id` or `key` of custom field"
},
"field_value": {
"fieldValue": {
"type": "string",
"example": "9039160788"
}
Expand All @@ -4078,7 +4077,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"type": "string",
"example": "My Text"
}
Expand All @@ -4098,7 +4097,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"type": "string",
"example": "My Text"
}
Expand All @@ -4118,7 +4117,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"type": "string",
"example": "My Selected Option"
}
Expand All @@ -4138,7 +4137,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"type": "string",
"example": "My Selected Option"
}
Expand All @@ -4158,7 +4157,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"type": "object",
"example": 100
}
Expand All @@ -4178,7 +4177,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"type": "object",
"example": 100.5
}
Expand All @@ -4198,7 +4197,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"example": [
"test",
"test2"
Expand All @@ -4224,7 +4223,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"example": [
"test",
"test2"
Expand All @@ -4250,7 +4249,7 @@
"type": "string",
"example": "my_custom_field"
},
"field_value": {
"fieldValue": {
"type": "object",
"example": {
"f31175d4-2b06-4fc6-b7bc-74cd814c68cb": {
Expand Down Expand Up @@ -4748,7 +4747,7 @@
"example": true
},
"contact": {
"$ref": "#/components/schemas/GetContectByIdSchema"

Check warning on line 4750 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
}
},
Expand Down Expand Up @@ -4903,7 +4902,7 @@
"example": true
},
"contact": {
"$ref": "#/components/schemas/GetContectByIdSchema"

Check warning on line 4905 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
},
"traceId": {
"type": "string"
Expand Down Expand Up @@ -4973,7 +4972,7 @@
"attributions": {
"type": "array",
"items": {
"$ref": "#/components/schemas/AttributionSource"

Check warning on line 4975 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
},
"followers": {
Expand Down Expand Up @@ -5025,7 +5024,7 @@
"contacts": {
"type": "array",
"items": {
"$ref": "#/components/schemas/ContactsSearchSchema"

Check warning on line 5027 in apps/contacts.json

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[INFO] Empty Array 

Details:
All array fields should not be empty

Recommendation:
The array should not be empty
}
},
"count": {
Expand Down