Feat/add supplementary materials #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… helpers - Add get_style_by_index(), get_color_palette(), get_hatch_palette(), create_legend_patches() to plot_utils.py - Replace duplicated model_colors/model_hatches definitions across RQ scripts - Enforce sequential order: 1st=blue+solid, 2nd=red+///, 3rd=orange+xxx - Remove ~80% duplicate styling code (~100 lines reduced)
- Remove p-value, sample size (n), significance stars from plot legends - Remove unused significance_stars function - Modernize type hints (List -> list, Tuple -> tuple) - Consolidate duplicate boxplot functions into reusable create_grouped_boxplot - Remove redundant generate_summary_stats functions - Simplify boolean filtering and output directory logic - Extract helper functions for better separation of concerns
- Fix LoRA parameters to match paper (rank=32, alpha=48) - Add note explaining 44% Hamming Loss reduction calculation for RQ2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.