-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use demo for tests. Fix docs #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/add_tests
branch
from
September 23, 2023 02:11
a32978a
to
6241adf
Compare
looks like CI is not happy. better to exclude the test in CI. |
I could try getting it working with xvfb? |
IanButterworth
force-pushed
the
ib/add_tests
branch
2 times, most recently
from
September 24, 2023 19:52
3ad457b
to
cbe07c3
Compare
IanButterworth
force-pushed
the
ib/add_tests
branch
from
September 24, 2023 20:04
cbe07c3
to
6037ddf
Compare
IanButterworth
force-pushed
the
ib/add_tests
branch
from
September 24, 2023 20:30
88993f8
to
09ac310
Compare
Should be good to review now @Gnimuc Just see #94 (comment) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package doesn't work for me on MacOS Silicon due to #74 and I was surprised to see there weren't any tests.
This